[border_css_util] implement css helper class #10057

scherler · 2024-12-13T14:43:50Z

This PR will provide CSS helper classes to add borders. It is similar to https://weekly.ci.jenkins.io/design-library/Spacing/ but takes more the way https://tailwindcss.com/docs/border-width works e.g. jenkins-border-t-3 will create a top border of 3 px

follow up pr will be created for https://weekly.ci.jenkins.io/design-library

Testing done

After compile you can change the source code to

    <div class="jenkins-border-t-4">
      Hello border
    </div>
    <div class="jenkins-border-dashed jenkins-border-b jenkins-border-t jenkins-border-blue">
      Hello border
    </div>
    <div class="jenkins-border jenkins-border-green">
      Hello border
    </div>

Proposed changelog entries

CSS helper classes to add borders in the spirit of the jenkins-!-spacing

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.
Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options

Signed-off-by: Thorsten Scherler <[email protected]>

janfaracik · 2024-12-13T20:23:45Z

Hey, thanks!

Is there a specific use case for these utils? Curious, wondering if it should be like the colours where we have a base palette but then a semantic set on top of them with specific meaning.

scherler · 2024-12-14T08:06:38Z

Mainly I was looking into this because of yui-button has borders but jenkins-button does not, some of our designs need those borders. Regarding the semantics I can implement that

janfaracik · 2024-12-14T08:51:14Z

Mainly I was looking into this because of yui-button has borders but jenkins-button does not, some of our designs need those borders. Regarding the semantics I can implement that

Ah gotcha. Is there any chance you could share a pic of what those buttons look like? Might be worth making a new type of button rather than a util library if its limited to that.

[border_css_util] implement css helper class

ea633ff

Signed-off-by: Thorsten Scherler <[email protected]>

alecharp added the web-ui The PR includes WebUI changes which may need special expertise label Dec 13, 2024

krisstern requested a review from janfaracik December 13, 2024 16:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[border_css_util] implement css helper class #10057

[border_css_util] implement css helper class #10057

scherler commented Dec 13, 2024 •

edited

Loading

Submitter checklist

Maintainer checklist

janfaracik commented Dec 13, 2024 •

edited

Loading

scherler commented Dec 14, 2024

janfaracik commented Dec 14, 2024

[border_css_util] implement css helper class #10057

Are you sure you want to change the base?

[border_css_util] implement css helper class #10057

Conversation

scherler commented Dec 13, 2024 • edited Loading

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

janfaracik commented Dec 13, 2024 • edited Loading

scherler commented Dec 14, 2024

janfaracik commented Dec 14, 2024

scherler commented Dec 13, 2024 •

edited

Loading

janfaracik commented Dec 13, 2024 •

edited

Loading